Repository navigation
Preserve exact integer conversion for subclasses - #405
Merged
dgilland merged 1 commit intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer subclasses such as IntEnum, and str subclasses containing integer text, currently fall through to float conversion in to_integer(). For example, 9007199254740993 becomes 9007199254740992, and sufficiently large values become 0 after float overflow.
Use exact built-in integer conversion for subclasses that retain the default conversion protocol. Explicitly overridden float methods keep their existing behavior. The returned value remains a built-in int, including for bool inputs.
Regression tests cover positive and negative large integers, IntEnum, int/str subclasses, and floating-point/invalid string fallbacks. This extends the exact-integer handling introduced in #299.
Validation on Windows / Python 3.12: